[Buildroot] [PATCH v2 1/1] shairplay-sync: new package

Jörg Krause jkrause at posteo.de
Sat Oct 25 13:41:02 UTC 2014


Dear Thomas,

Am 25.10.2014 12:29 schrieb Thomas Petazzoni:
> Dear Jörg Krause,
> 
> On Sat, 25 Oct 2014 00:55:41 +0200, Jörg Krause wrote:
>> Signed-off-by: Jörg Krause <jkrause at posteo.de>
>> ---
>> Changes v1 -> v2:
>>   - autoselect SSL backend instead of a user choice
>>   - autoselect zeroconf backend instead of a user choice
>>   - fix missing select for optional package libsoxr
>>   - fix config option for avahi (--with-avahi instead of 
>> --with-openssl)
>>   - add comment to tinysvcmdns in shairport-sync.mk
> 
> Applied, after doing a few tweaks:
> 
>     [Thomas:
>      - rework init script to be more like other Buildroot init scripts,
>        and fix indentation.
>      - fix indentation in the .mk file
>      - remove dependencies on host-autoconf and host-libtool, since the
>        package has AUTORECONF = YES, this is not needed.
>      - fix licensing informations.]


Many thanks for the thorough review! You even checked the license!

One question to the init script file: shairport-sync uses libdaemon for 
creating the pidfile. Does this conflicts with the `-p` switch of 
start-stop-daemon?

Best regards
Jörg



More information about the buildroot mailing list