[Buildroot] [PATCH 1/2] kconfig/lxdialog: get ncurses CFLAGS with pkg-config

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Oct 26 15:41:55 UTC 2014


Dear Bjørn Forsman,

On Sun, 26 Oct 2014 14:17:25 +0100, Bjørn Forsman wrote:
> This makes "make menuconfig" also work on systems where ncurses is not
> installed in a standard location (such as on NixOS).
> 
> This patch changes ccflags() so that it tries pkg-config first, and only
> if pkg-config fails does it go back to the fallback/manual checks. This
> is the same algorithm that ldflags() already uses.
> 
> [This patch is already applied upstream (will be part of linux v3.18):
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=be8af2d54a66911693eddc556e4f7a866670082b
> 
> I'm adding this instead of doing a full upstream kconfig sync because
> (1) there was a conflict in one of the Buildroot kconfg patches (against
> linux 3.18-rc1), (2) adding this patch won't create any conflict next
> time someone re-syncs kconfig with linux and (3) because this is easier
> to review.
> ]
> 
> Signed-off-by: Bjørn Forsman <bjorn.forsman at gmail.com>
> ---
>  support/kconfig/lxdialog/check-lxdialog.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>  mode change 100644 => 100755 support/kconfig/lxdialog/check-lxdialog.sh

Hum, whenever we do change in the kconfig code, we like them to be part
of the patch series we have. See support/kconfig/README.buildroot for
details. In this case, indeed, the fix is already upstream. But still,
we would like to keep separated the base kconfig version (copied
as-is from the kernel) from any further modification we have made.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list