[Buildroot] [PATCHv2 buildroot-test 01/11] autobuild-run: check-requirements does not need to know the login details

[Thomas De Schampheleire]

On Mon, Oct 27, 2014 at 6:56 PM, Peter Korsgaard <jacmet at uclibc.org> wrote:
>>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin at gmail.com> writes:
>
> Hi,
>
>  >> are you not overlooking another place where http_login + http_password
>  >> are used to find out whether uploading should take place? I.e, in:
>  >>
>  >> if http_login and http_password:
>  >> # Submit results. Yes, Python has some HTTP libraries, but
>  >> # none of the ones that are part of the standard library can
>  >> # upload a file without writing dozens of lines of code.
>  >>
>  >> Probably we want the same test to be used everywhere?
>
>  > Hmm, indeed.
>  > But then I think we better add do_send_results to kwargs so the value
>  > can be calculated once and used multiple times. Btw, if you have a
>  > better name than do_send_results, that would be great. I'd pick
>  > 'send_results' but it's already the function name...
>
> What about 'upload'?

Sounds good to me.
Thomas Petazzoni: do you agree?

Thanks,
Thomas