[Buildroot] [PATCH 1/1] miraclecast: new package

Baruch Siach baruch at tkos.co.il
Fri Apr 3 05:00:43 UTC 2015


Hi Ryan,

On Thu, Apr 02, 2015 at 10:10:34PM -0500, Ryan Barnett wrote:
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 98bda02..a94ce04 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -77,6 +77,11 @@ else
>  SYSTEMD_CONF_OPTS += --disable-seccomp
>  endif
>  
> +ifeq ($(BR2_PACKAGE_MIRACLECAST),y)
> +# Must enable kdbus in order to get sd-events.h in staging
> +SYSTEMD_CONF_OPTS += --enable-kdbus
> +endif

This looks somewhat unusual. And besides, kdbus should be a useful feature on 
its own right. So why not add a BR2_PACKAGE_SYSTEMD_KDBUS option, and have 
BR2_PACKAGE_MIRACLECAST select that? Setting the right kernel dependency for 
BR2_PACKAGE_SYSTEMD_KDBUS would be an interesting question, though.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list