[Buildroot] [PATCH v2] pkg-*.mk: add comment about argument 1 of inner-*-package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Apr 9 12:32:06 UTC 2015


Dear Masahiro Yamada,

On Thu,  9 Apr 2015 21:14:26 +0900, Masahiro Yamada wrote:

> -#  argument 1 is the lowercase package name
> +#  argument 1 is the lowercase package name, including a host_ prefix
> +#             for host packages

The prefix is 'host-', not 'host_'. Though I'm not sure this comment is
really that useful: host-foo is really the name of the package. Since
there is no parameter containing the lower case package name without
the 'host-' prefix, I don't think such an additional comment is really
needed.

The comment is needed for argument 2 and 3, because they are indeed
different in the fact that one has HOST_ and not the other one.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list