[Buildroot] [PATCH] pkg-utils: update comments after renaming of package infra macros

Yann E. MORIN yann.morin.1998 at free.fr
Mon Apr 13 19:53:17 UTC 2015


Thomas, All,

On 2015-04-13 11:53 +0200, Thomas Petazzoni spake thusly:
> The package infrastructure macros have a long time ago been renamed
> from GENTARGETS, AUTOTARGETS to generic-package and
> autotools-package. However, one comment in pkg-utils.mk keeps a
> reference to these *TARGETS macros. This commit updates this comment
> to match the new name of these macros.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

I was puzzled as to why I could still see 'TARGETS' even after your
series was applied. This squashes that concenr of mine on your series. ;-)

Regards,
Yann E. MORIN.

> ---
>  package/pkg-utils.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 7eddc47..5a385f8 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -60,7 +60,7 @@ endef
>  
>  # Helper functions to determine the name of a package and its
>  # directory from its makefile directory, using the $(MAKEFILE_LIST)
> -# variable provided by make. This is used by the *TARGETS macros to
> +# variable provided by make. This is used by the *-package macros to
>  # automagically find where the package is located.
>  pkgdir = $(dir $(lastword $(MAKEFILE_LIST)))
>  pkgname = $(lastword $(subst /, ,$(pkgdir)))
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list