[Buildroot] [PATCH] pkg-cmake: Skip compilation in installation step

[Cédric Marie]

Hi,

> Would it also make sense we install cmake itself with this rule, in
> package/cmake/cmake.mk:47 , too?

That could make sense, yes. I had not thought about CMake being compiled 
with CMake generated makefiles.


> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> 
>  Doing it for host-cmake itself can be a separate patch. And not very 
> important
> either, I can't measure the time difference...

OK for a separate patch.

I agree the time difference is not so big. But it can be several seconds 
with some packages (it is done twice: staging + target). When you have 
to rebuild your package regularly, you certainly appreciate saving these 
few seconds. I do :)

In fact, it is a little bit strange that the default behaviour of CMake 
install is to compile before installing. I understand it can be useful 
to check that everything is up-to-date, and maybe check if a new 
installation rule has been added. But outside Buildroot, when installing 
a CMake package to your computer, it might result in compiling with root 
privileges (since make install is likely to be called with root 
privileges). This point is out-of-scope regarding Buildroot, I was just 
wondering about CMake default behaviour...


-- 
Cédric