[Buildroot] [PATCH 1/2] package/ccache: bump to version 3.2.1
Baruch Siach
baruch at tkos.co.il
Sun Apr 26 09:41:57 UTC 2015
Hi Károly,
On Sun, Apr 26, 2015 at 11:38:52AM +0200, Károly Kasza wrote:
> > > - sed -i 's,getenv("CCACHE_COMPILERCHECK"),"none",' $(@D)/ccache.c
> > > - sed -i 's,"%s/.ccache","$(BR_CACHE_DIR)",' $(@D)/ccache.c
> > > + sed -i 's,conf->compiler_check =
> > x_strdup("mtime"),conf->compiler_check = x_strdup("none"),' $(@D)/conf.c
> > > + sed -i 's,"%s/.ccache","$(BR_CACHE_DIR)",' $(@D)/conf.c
> >
> > You are doing non trivial changes here and above. Please explain in a
> > commit log what you are doing, and why this is needed as part of the
> > version bump.
>
> As you probably see, those lines do the exact same as before, just the
> structure of the ccache sources changed with the major version bump. I'll
> wait for some comments on the second patch regarding the introduction of a
> wrapper script and resend with a more informative git log.
Thanks. When doing so please comment also on the _HOOKS change.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
More information about the buildroot
mailing list