[Buildroot] [PATCH] Makefile: remove redundant ifdef V

Baruch Siach baruch at tkos.co.il
Tue Apr 7 04:19:11 UTC 2015


Hi Masahiro Yamada,

On Tue, Apr 07, 2015 at 01:08:16PM +0900, Masahiro Yamada wrote:
> If "V" is not defined, "$(origin V)" returns "undefined".
> "ifdev V" is redundant.

V is not defined in code but ...

> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
> 
>  Makefile | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index d6426b3..9db52a8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -184,10 +184,8 @@ endif
>  
>  # To put more focus on warnings, be less verbose as default
>  # Use 'make V=1' to see the full commands

... as this comment says, you can define V manually on the make invocation 
command line. That is its intended use.

> -ifdef V
> -  ifeq ("$(origin V)", "command line")
> -    KBUILD_VERBOSE = $(V)
> -  endif
> +ifeq ("$(origin V)", "command line")
> +  KBUILD_VERBOSE = $(V)
>  endif
>  ifndef KBUILD_VERBOSE
>    KBUILD_VERBOSE = 0

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list