[Buildroot] [PATCH v4 2015.08 3/4] Makefile: implement a size-stats target

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Aug 20 20:43:56 UTC 2015


Ryan,

On Thu, 20 Aug 2015 07:42:39 -0500, Ryan Barnett wrote:

> > +size-stats:
> > +       $(Q)mkdir -p $(GRAPHS_DIR)
> > +       $(Q)$(TOPDIR)/support/scripts/size-stats --builddir $(BASE_DIR) \
> > +               --graph $(BASE_DIR)/graphs/graph-size.$(BR_GRAPH_OUT) \
> > +               --file-size-csv $(BASE_DIR)/build/file-size-stats.csv \
> > +               --package-size-csv $(BASE_DIR)/build/package-size-stats.csv \
> > +               --skeleton-path $(TARGET_SKELETON)
> 
> In order to make this patch series to continue to work with the recent
> addition of the skeleton package, the --skeleton-path variable needs
> to be updated to:
> 
>    --skeleton-path $(SKELETON_PATH)
> 
> I don't know if you have already updated this or not in your patch
> series but this change needs to be in order to have the graph
> statistics work.

I haven't had the time to update the series unfortunately. However, now
that the skeleton is a real package, I believe all the special handling
of the skeleton can be removed from this size-stats mechanism. It will
simply be handled as a normal package.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list