[Buildroot] [PATCH/next 05/10] package/libcodec2: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Aug 29 10:42:18 UTC 2015


Dear Bernd Kuhls,

On Tue, 11 Aug 2015 20:16:50 +0200, Bernd Kuhls wrote:
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
> ---
>  package/Config.in                             |  1 +
>  package/libcodec2/0001-cross.patch            | 44 +++++++++++++++++++++++++++
>  package/libcodec2/0002-disable-unittest.patch | 13 ++++++++
>  package/libcodec2/Config.in                   |  7 +++++
>  package/libcodec2/libcodec2.mk                | 23 ++++++++++++++
>  5 files changed, 88 insertions(+)
>  create mode 100644 package/libcodec2/0001-cross.patch
>  create mode 100644 package/libcodec2/0002-disable-unittest.patch
>  create mode 100644 package/libcodec2/Config.in
>  create mode 100644 package/libcodec2/libcodec2.mk

The two patches you added were not written in a way that makes them
upstreamable. Since upstream seems to be active, this is a little bit
sad.

So, I've replaced them by patches that can actually be upstream:

 * For generate_cookbook, I've added a patch that integrates the
   AX_CC_FOR_BUILD Autoconf macro from the GNU Autoconf Archive, and
   use that to build generate_cookbook.

 * For the unit tests, I've simply added a --enable/--disable option.

Could you take care of pushing the patches upstream? Another patch that
would be useful to push upstream is a patch to pass the subdir-objects
automake option, which would avoid a huge amount of warning when
autoreconfiguring the package.

I've applied your patch with those changes, to the next branch. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list