[Buildroot] [PATCH 1/1] Fix Image name not configurable (issue #28).

[Mauro Condarelli]

Yann, All,

After the previous discussion on IRC I came up with this very different patch which does not touch the upstream package at all (even though I still think allowing user to chose isn't evil).
Before I try to submit it I would like a comment.
The aim is to force the booted image name according to requested kernel target if (and only if) user contextually requests the image to be installed.
Obvious downside is user has no feedback of the change (and I don't know how to provide this feedback).
Would this be more acceptable?

diff --git a/boot/at91bootstrap3/at91bootstrap3.mk b/boot/at91bootstrap3/at91bootstrap3.mk
index fa67ea6..ccb5e95 100644
--- a/boot/at91bootstrap3/at91bootstrap3.mk
+++ b/boot/at91bootstrap3/at91bootstrap3.mk
@@ -40,6 +40,23 @@ define AT91BOOTSTRAP3_INSTALL_IMAGES_CMDS
         cp $(@D)/binaries/*.bin $(BINARIES_DIR)
  endef
+ifeq ($(BR2_LINUX_KERNEL_INSTALL_TARGET),y)
+define AT91BOOTSTRAP3_KCONFIG_FIXUP_CMDS
+       $(if $(BR2_LINUX_KERNEL_UIMAGE),
+               $(call KCONFIG_SET_OPT,CONFIG_IMAGE_NAME,"uImage",$(@D)/.config))
+       $(if $(BR2_LINUX_KERNEL_APPENDED_UIMAGE),
+               $(call KCONFIG_SET_OPT,CONFIG_IMAGE_NAME,"uImage",$(@D)/.config))
+       $(if $(BR2_LINUX_KERNEL_ZIMAGE),
+               $(call KCONFIG_SET_OPT,CONFIG_IMAGE_NAME,"zImage",$(@D)/.config))
+       $(if $(BR2_LINUX_KERNEL_APPENDED_ZIMAGE),
+               $(call KCONFIG_SET_OPT,CONFIG_IMAGE_NAME,"zImage",$(@D)/.config))
+       $(if $(BR2_LINUX_KERNEL_VMLINUX),
+               $(call KCONFIG_SET_OPT,CONFIG_IMAGE_NAME,"vmlinux",$(@D)/.config))
+       $(if $(BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM),
+               $(call KCONFIG_SET_OPT,CONFIG_IMAGE_NAME,$(BR2_LINUX_KERNEL_IMAGE_NAME),$(@D)/.config))
+endef
+endif
+
  ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_USE_DEFCONFIG),y)
  AT91BOOTSTRAP3_SOURCE_CONFIG = $(AT91BOOTSTRAP3_DIR)/board/*/$(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG))_defconfig
  else ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_USE_CUSTOM_CONFIG),y)


Il 29/08/2015 13:59, Yann E. MORIN ha scritto:
> ...
> I'm marking this patch as rejected in Patchwork. Regards, Yann E. MORIN.
understood.

Regards
Mauro