[Buildroot] CMake and VERBOSE variable

[Cédric Marie]

Hi,

Le 23/08/2015 01:10, Arnout Vandecappelle a écrit :
>> When V=1, we should export Q = (empty) and a new variable BR2_VERBOSE = 1.
>> When V=0, we should export Q = @ and BR2_VERBOSE = (empty).
>
>   I don't think we should export anything at all, we should really do it per
> build system (which is problematic for generic-package of course).

You're right for Q. It is used in pkg-generic.mk, and should be defined 
only in this file, depending on V value and origin.

The benefits to exporting a new variable BR2_VERBOSE, is that we can 
check V value (0 or 1) and origin ("command line"?) only once, instead 
of repeating this double test in every .mk.

So now, thanks to your remarks, I've got something that is working for 
cmake and autotools.

* I have removed these exports from root Makefile: quiet Q KBUILD_VERBOSE.

* In pkg-generic.mk, I define Q=(empty) if V=1 from the command line, 
and Q=@ otherwise.

* In pkg-cmake.mk, I add "VERBOSE=1" in build command when V=1 from the 
command line.
(checked with libcuefile)

* In pkg-autotools.mk, I add "V=1" in build command when V=1 from the 
command line (and "V=0" otherwise, because V=1 is the default).
(checked with libpthsem)
NB: It would not even be necessary to modify pkg-autotools.mk, if V=0 
was the default.

I think that these modifications keep the behaviour unchanged.

Can I provide a patch with that?

Do you prefer to check V value and origin in all pkg-*.mk, or should I 
use BR2_VERBOSE to compute it once?

Waiting for your feedback,
Regards.

-- 
Cédric