[Buildroot] [PATCH 1/2] wine: Make the sane-config patch obsolete by using configure flags

André Hentschel nerv at dawncrow.de
Tue Dec 8 21:02:28 UTC 2015


Am 08.12.2015 um 09:48 schrieb Thomas Petazzoni:
> André,
> 
> On Mon, 7 Dec 2015 21:39:22 +0100, André Hentschel wrote:
>> Signed-off-by: André Hentschel <nerv at dawncrow.de>
>> ---
>>  package/wine/0003-sane-config-fix.patch | 21 ---------------------
>>  package/wine/wine.mk                    |  3 ++-
>>  2 files changed, 2 insertions(+), 22 deletions(-)
>>  delete mode 100644 package/wine/0003-sane-config-fix.patch
> 
> IMO, this is not the good choice. The patch should be kept and
> submitted upstream. There is absolutely no reason for upstream to
> reject the patch: it simply *adds* the possibility of passing a custom
> sane-config path through SANE_CONFIG, without changing *anything* to
> the existing behavior if SANE_CONFIG is not used.
> 

Hi Thomas,
rebase it, send it to wine-patches at winehq.org (maybe you need to register first, not sure), I'll also sign it off, but I totally doubt it gets in.
One point might be that there's already a way with the variables I used in my patch or that your patch is not generic enough.



More information about the buildroot mailing list