[Buildroot] [PATCH 04/13 v2] core/legal-info: ensure legal-info works in off-line mode
Yann E. MORIN
yann.morin.1998 at free.fr
Wed Dec 16 23:05:03 UTC 2015
Luca, All,
On 2015-12-16 23:47 +0100, Luca Ceresoli spake thusly:
> Luca Ceresoli wrote:
> [...]
> >>+# Download actual sources if they differ from the extracted sources
> >>+# (e.g. for external toolchains)
> >>+#
> >>+# We need to provide PKG and PKGDIR, because there's no .stamp file for
> >>+# the legal-info step.
> >>+$(1)-legal-source: PKG=$(2)
> >>+$(1)-legal-source: PKGDIR=$(pkgdir)
> >>+$(1)-legal-source:
> >>+ifneq ($$($(2)_ACTUAL_SOURCE_TARBALL),)
> >>+ifneq ($$($(2)_ACTUAL_SOURCE_TARBALL),$$($(2)_SOURCE))
> >>+ $$(call
> >>DOWNLOAD,$$($(2)_ACTUAL_SOURCE_SITE)/$$($(2)_ACTUAL_SOURCE_TARBALL))
> >>+endif # actuall sources != sources
> >
> >actuall sources -> actual source
> >
> >>+endif # actuall source != ""
> >
> >actuall -> actual
> >
> >With these fixed:
> > Acked-by: Luca Ceresoli <luca at lucaceresoli.net>
> >
> >[Tested with a minimal Sourcery ARM 2014.05 config]
> >Tested-by: Luca Ceresoli <luca at lucaceresoli.net>
>
> Hey, NO! This patch is wrong.
[--SNIP--]
> with this defconfig:
>
> BR2_arm=y
> BR2_TOOLCHAIN_EXTERNAL=y
>
> But it breaks online 'make legal-info' when _ACTUAL_SOURCES have not
> yet been downloaded, i.e.:
>
> $ make clean
> $ rm -fr dl/
> $ make legal-info
> [...]
> cp: cannot stat '/home/murray/devel/buildroot/dl/arm-2014.05-29-arm-none-linux-gnueabi.src.tar.bz2':
> No such file or directory
Damit... :-(
> I think this is because you moved the downloading of _ACTUAL_SOURCE
> from the $(1)-legal-info to $(1)-legal-source, and the former does not
> depend on the latter.
>
> Perhaps we just need this?
>
> $(1)-legal-info: $(1)-legal-source
Nope, that does not work either. The download indeed occurs, but then it
can not find a hash for it. Indeed, we do not have ssuch a hash
anywhere.
I'll investigate tomorrow (or this WE).
> Sorry for having missed this during my first review.
No problem, thank you very much for the testing! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list