[Buildroot] [PATCH] tpm-tools: fix build failures caused by -Werror
DATACOM - henrique.marks
henrique.marks at datacom.ind.br
Mon Dec 28 15:28:03 UTC 2015
Isn't better to fix the code, instead of taking off -Werror ?
If it is not possible to fix the code (a huge amount of errors, for instance, caused by a new compiler version), maybe some -Wno directive would be better.
Thanks
----- Mensagem original -----
> De: "Thomas Petazzoni" <thomas.petazzoni at free-electrons.com>
> Para: "Noé Rubinstein" <noe.rubinstein at gmail.com>
> Cc: "Noé Rubinstein" <nrubinstein at aldebaran.com>, buildroot at buildroot.org
> Enviadas: Segunda-feira, 28 de dezembro de 2015 11:37:49
> Assunto: Re: [Buildroot] [PATCH] tpm-tools: fix build failures caused by -Werror
> Noé,
>
> On Mon, 28 Dec 2015 14:30:56 +0100, Noé Rubinstein wrote:
>> Change-Id: I1797d19039938e750c92bb89d05b2f05c10668ad
>
> We don't need a Change-Id. We need a Signed-off-by line as well as a
> reference to the autobuilder failure that you are fixing. And also a
> short explanation on how you're fixing the failure (backport an
> upstream patch, etc.).
>
>
>> diff --git a/package/tpm-tools/tpm-tools.mk b/package/tpm-tools/tpm-tools.mk
>> index 20df489..9e4d66a 100644
>> --- a/package/tpm-tools/tpm-tools.mk
>> +++ b/package/tpm-tools/tpm-tools.mk
>> @@ -11,6 +11,7 @@ TPM_TOOLS_STRIP_COMPONENTS = 2
>> TPM_TOOLS_LICENSE = Common Public License Version 1.0
>> TPM_TOOLS_LICENSE_FILES = LICENSE
>> TPM_TOOLS_DEPENDENCIES = trousers openssl
>> +TPM_TOOLS_AUTORECONF = yes
>
> Please add a comment:
>
> # We're patching configure.in
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Dr. Henrique Marks
henrique.marks at datacom.ind.br
R. América, 1000 - Eldorado do Sul - RS
CEP: 92990-000 - Brasil
Fone: +55 51 3933 3000 - Ramal 3466
More information about the buildroot
mailing list