[Buildroot] [PATCH 08/84 RFC] package/alsa-utils: use 'menuconfig' instead of 'config'+'menu'

Arnout Vandecappelle arnout at mind.be
Wed Dec 30 23:03:16 UTC 2015


On 25-12-15 22:24, Yann E. MORIN wrote:
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> ---
>  package/alsa-utils/Config.in | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/package/alsa-utils/Config.in b/package/alsa-utils/Config.in
> index a08743e..762fcdf 100644
> --- a/package/alsa-utils/Config.in
> +++ b/package/alsa-utils/Config.in
> @@ -2,7 +2,7 @@ comment "alsa-utils needs a toolchain w/ threads"
>  	depends on BR2_USE_MMU # fork
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS
>  
> -config BR2_PACKAGE_ALSA_UTILS
> +menuconfig BR2_PACKAGE_ALSA_UTILS
>  	bool "alsa-utils"
>  	depends on BR2_USE_MMU # fork
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> @@ -15,7 +15,8 @@ config BR2_PACKAGE_ALSA_UTILS
>  	  http://www.alsa-project.org/
>  
>  if BR2_PACKAGE_ALSA_UTILS
> -menu "ALSA utils selection"
> +
> +comment  "ALSA utils selection"

 I don't think this comment is needed. Also, why do you do it for alsa-utils but
not alsa-lib?

 Regards,
 Arnout

>  
>  config BR2_PACKAGE_ALSA_UTILS_ALSACONF
>  	bool "alsaconf"
> @@ -85,6 +86,4 @@ config BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST
>  	select BR2_PACKAGE_ALSA_LIB_PCM
>  	bool "speaker-test"
>  
> -endmenu
> -
>  endif
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list