[Buildroot] [PATCH v3 1/3] pkg-generic.mk: reinstall targets

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Feb 1 10:59:13 UTC 2015


Dear Yann E. MORIN,

On Sun, 1 Feb 2015 11:55:01 +0100, Yann E. MORIN wrote:

> I am not very happy with the fact that we add new actions here; the rest
> of the code block is so far only concerned about ordering, not the
> actual commands to execute.
> 
> The only other similar make target that removes stuff is the
> $(1)-dirclean target, that uses a fake stamp-file (that it actually does
> not touch) to actually does the cleanup.

I am not sure what you mean here. Look at the existing
$(1)-clean-for-rebuild and $(1)-clean-for-reconfigure targets. They
also do some commands to remove the stamp files. So what Doug has done
here is to simply replicate the same logic, but removing less stamp
files to only retrigger installation and not configuration and/or
compilation.

So I believe the implementation proposed by Doug is well-aligned with
what we already do. Unless I misunderstood your comment, obviously.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list