[Buildroot] [PATCH v4 03/17] package/pkg-rebar: new infrastructure

[Johan Oudinet]

Thomas, All,

On Mon, Jan 5, 2015 at 10:31 AM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> On Sun, 4 Jan 2015 23:20:38 +0100, Yann E. MORIN wrote:
>> > > +# Define the build and install commands
>> > > +#
>> > > +ifeq ($(4),target)
>> > > +
>> > > +ifeq ($$($(2)_CONFIGURE),YES)
>> >
>> > What is $(2)_CONFIGURE exactly? It is not documented in PATCH 04/17.
>>
>> Some rebar packages use autotools for the configure step, and use rebar
>> for the build step. Worse, some of them even require being autoreconf-ed.
>>
>> This variable, if set to YES, means that this package will use the
>> autotools-package infrastrucutre; otherwise, it will be trated as a
>> generic-package.
>
> Not sure of a better name for this one. Maybe $(2)_USE_AUTOTOOLS,
> defaults to no, can be overridden to YES by the packages having a
> configure script? Do they both autoconf and automake, or just autoconf?
> I guess the latter, so maybe $(2)_USE_AUTOCONF.

They use autoconf only (mostly for the rebar.config.in file). So, I
vote for $(2)_USE_AUTOCONF.

-- 
Johan
()  ascii ribbon campaign - against html e-mail
/\  www.asciiribbon.org   - against proprietary attachments