[Buildroot] [PATCH v3] Allow a single DHCP configuration via the system configuration submenu

[Gustavo Zacarias]

On 01/09/2015 07:28 AM, Károly Kasza wrote:

Hi Jérémy, Károly, the rest.

> Tested-by: Karoly Kasza <kaszak at gmail.com <mailto:kaszak at gmail.com>>
> Reviewed-by: Karoly Kasza <kaszak at gmail.com <mailto:kaszak at gmail.com>>
> 
> Tested with uClibc, successfully built different rootfs.ext images and
> booted them.
> Tested with master branch, x86_64 arch in QEMU, internal toolchain GCC
> 4.9.2 w/ uclibc, Linux 3.18.1.
> 
> I recommend maybe adding a dependency in Config.in later for package
> ifupdown (not yet merged, proposed by Gustavo), if no Busybox is present
> in the system.

I wouldn't go as far as selecting ifupdown, but possibly depending on
BR2_PACKAGE_BUSYBOX | BR2_PACKAGE_IFUPDOWN because the option will
always be "set" (it's a string) and you can't do that easily.
That way the option will vanish if there's no proper provider of
ifupdown which is the interpreter of /etc/network/interfaces.
Of course busybox may lack ifupdown for custom configs, but that's the
case for so many things (a shell, for example) that we can't cover weird
scenarios in a sane way, and it might just be intended.
Other than that:

Tested-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
Acked-by: Gustavo Zacarias <gustavo at zacarias.com.ar>

(qemu-arm-versatile-defconfig default busybox init and systemd).
Regards.