[Buildroot] [PATCH v3 1/1] board: add support for WarPboard

[Arthur LAMBERT]

Le Tuesday 30 Jun 2015 à 23:29:41 (+0200), Thomas Petazzoni a écrit :
> Dear Arthur LAMBERT,
> 
> On Fri, 26 Jun 2015 15:13:25 +0200, Arthur LAMBERT wrote:
> > This is a set of patch to add support for warpboard (Freescale board based on imx6sl)
> > 
> > The patch contains :
> >   - defconfig for warpboard
> >   - linux patches from Fabio Estevam to fix device tree due to last change on warpboard schematics (rev 1.12)
> >   and to fix kernel imx_v6_v7 defconfig which use incorrect hci protocol
> >   - specific firmware file for warpboard bluetooth (nvram : brcmfmac4330-sdio.txt)
> 
> That's a detail, but the commit log should be wrapped to 80 columns.
> 
> 
> 

I will fix that

> > +- transfer uboot into flash by running this command in host side:
> > + $ sudo dfu-util -D output/images/u-boot.imx -a boot
> 
> So maybe you should build the host-dfu-util package of Buildroot by
> selecting it in the Buildroot defconfig, and use it here?
> 

Very legit request.

> > +- remove power and put warpboard into normal boot mode by opening the jumper.
> > +
> > +Update linux & rootfs
> > +=====================
> > +
> > +Use ums command from uboot prompt to mount emmc as mass storage and update zImage, device tree and rootfs file
> 
> Which rootfs file? The tarball or the ext2 one?

I will add more detail in this section

> 
> > +Enable bluetooth (need to enable bluez-util)
> > +================
> > +hciattach /dev/ttymxc4 any
> > +hciconfig hci0 up
> 
> Maybe:
> 
> Using Bluetooth
> ===============
> 
> Enable the bluez_utils package, and then:
> 
> $ hciattach /dev/ttymxc4 any
> $ hciconfig hci0 up
> 
> Of course, make sure you're really talking about bluez_utils or
> bluez_utils5, we have two separate packages in Buildroot.
> 

Both version are working great.

> Could you take into account those minor comments, and send an updated
> version?
> 

No problem, V4 is coming !

> Thanks!
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com