[Buildroot] [PATCH v7 21/22] mtd: Add xattr support

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jul 6 10:35:51 UTC 2015


Dear Clayton Shotwell,

On Tue,  2 Jun 2015 08:28:37 -0500, Clayton Shotwell wrote:

> -HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-e2fsprogs
> +MTD_MAKE_OPTS = WITHOUT_LARGEFILE=1
> +
> +# If extended attributes are required, the acl package must
> +# also be enabled which will also include the attr package.
> +ifeq ($(BR2_PACKAGE_ACL),y)
> +MTD_DEPENDENCIES += acl
> +MTD_MAKE_OPTS += WITHOUT_XATTR=0
> +else
> +MTD_MAKE_OPTS += WITHOUT_XATTR=1
> +endif
> +
> +HOST_MTD_DEPENDENCIES += host-zlib host-lzo host-e2fsprogs

The change from = to += for HOST_MTD_DEPENDENCIES was unnecessary.

I've applied your patch after changing this.

However, this basically only changes mkfs.jffs2 on the target. Do you
really use mkfs.jffs2 on the target? Don't you also need xattr support
in the host mkfs.jffs2 ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list