[Buildroot] [PATCH v2 1/1] package/modem-manager: init script for systemV-like init systems
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Jul 2 10:29:29 UTC 2015
Petr,
On Wed, 1 Jul 2015 22:11:12 +0200, Petr Vorel wrote:
> +MODEMMANAGER_BIN=/usr/sbin/ModemManager
This variable was not needed, it's only used once, so I've just used
directly the path to ModemManager.
> +PIDFILE=/var/run/ModemManager.pid
> +
> +[ -x $MODEMMANAGER_BIN ] || exit 0
> +
> +start() {
> + echo -n "Starting ModemManager: "
> + umask 077
> + start-stop-daemon -S -q -b -m -p $PIDFILE \
> + --exec $MODEMMANAGER_BIN
> + ret=$?
> + [ $ret = 0 ] && echo "OK" || echo "FAIL"
ret variable not really needed.
> +}
> +stop() {
> + echo -n "Stopping ModemManager: "
> + start-stop-daemon -K -q -p $PIDFILE
> + ret=$?
> + [ $ret = 0 ] && { echo "OK"; rm -f $PIDFILE; } || echo "FAIL"
Ditto.
> +define MODEM_MANAGER_INSTALL_INIT_SYSV
> + $(INSTALL) -m 0755 -D package/modem-manager/S44modem-manager $(TARGET_DIR)/etc/init.d/S44modem-manager
Line slightly too long, so I've broken it up with a \
Applied with those minor nits fixed!
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list