[Buildroot] [PATCH v7 7/7] package/vlc: add opencv support

[Samuel Martin]

Yann,

On Sun, Jul 5, 2015 at 11:39 AM, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Samuel, all,
>
> On 2015-07-04 21:07 +0200, Samuel Martin spake thusly:
>> This change adds 2 patches (backported from upstream) to vlc fixing the
>> build against opencv2 APIs.
>> This allows to select the minimal set of opencv modules when opencv
>> support is enabled.
>>
>> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
>> Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>
> This reviewd tag stands, still I have a question:
>
>> diff --git a/package/vlc/Config.in b/package/vlc/Config.in
>> index b030a56..471f4a7 100644
>> --- a/package/vlc/Config.in
>> +++ b/package/vlc/Config.in
>> @@ -11,6 +11,8 @@ config BR2_PACKAGE_VLC
>>       depends on BR2_TOOLCHAIN_HAS_THREADS
>>       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
>>       select BR2_PACKAGE_LIBVORBIS if BR2_PACKAGE_OPUS
>> +     select BR2_PACKAGE_OPENCV_LIB_IMGPROC if BR2_PACKAGE_OPENCV
>> +     select BR2_PACKAGE_OPENCV_LIB_OBJDETECT if BR2_PACKAGE_OPENCV
>
> objdetect already selects imgproc. So, does vlc w/ opencv really need
> imgproc by itself? If so, the select is OK, otherwise, it is
> superfluous.

I select all opencv's modules used in the vlc code-base [1].

[1] http://git.videolan.org/gitweb.cgi/vlc.git/?p=vlc.git;a=blob;f=modules/video_filter/opencv_example.cpp;h=998f286ba2269fdf1680b375c1f849d24598742d;hb=HEAD#l42


Regards,

-- 
Samuel