[Buildroot] [PATCH v8 3/7] package/opencv: add a choice for selecting the gui toolkit
Samuel Martin
s.martin49 at gmail.com
Sun Jul 5 12:56:15 UTC 2015
Thomas,
On Sun, Jul 5, 2015 at 2:53 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Samuel Martin,
>
> On Sun, 5 Jul 2015 11:40:25 +0200, Samuel Martin wrote:
>
>> +choice
>> + prompt "gui toolkit"
>> + depends on BR2_PACKAGE_OPENCV_LIB_HIGHGUI
>> + help
>> + GUI toolkit for opencv_highgui module.
>> +
>> + The best toolkit to work with OpenCV are, in decreasing order of
>> + preference by the OpenCV build system):
>> + - Qt4
>> + - gtk2
>> +
>> + Note that, whatever you choose here will be used by OpenCV, even
>> + if you also enabled a more preferred toolkit in your Buildroot
>> + configuration.
>
> This comment really doesn't make sense. Why do we care about the
> preferred order of OpenCV for GUI toolkit, since we are anyway
> overriding it by the below options? Why don't you simply have:
>
> help
> GUI toolkit to be used by the opencv_highgui module.
>
> The additional comments about the preferred order by OpenCV build
> system are simply confusing and useless, IMO. If you agree, I can apply
> this patch after reworking the comment.
>
I'm fine with this.
Thanks,
--
Samuel
More information about the buildroot
mailing list