[Buildroot] [PATCH 1/1] ntp: drop uselss patch fixup which sometimes breaks rebuild

Danomi Manchego danomimanchego123 at gmail.com
Mon Jul 6 01:59:23 UTC 2015


Yann,

>> diff --git a/package/ntp/ntp.mk b/package/ntp/ntp.mk
>> index 5f05508..93cefa1 100644
>> --- a/package/ntp/ntp.mk
>> +++ b/package/ntp/ntp.mk
>> @@ -42,7 +42,6 @@ endif
>>
>>  define NTP_PATCH_FIXUPS
>>       $(SED) "s,^#if.*__GLIBC__.*_BSD_SOURCE.*$$,#if 0," $(@D)/ntpd/refclock_pcf.c
>
> As far as I could see, that one line does not do anything either.

It *does* change the file - though, I don't know if the change is
actually necessary.  Verified by doing:

$ rm -rf output/build/ntp-4.2.8p3/
$ make -s ntp-extract
$ cp -ra output/build/ntp-4.2.8p3/ .
$ make -s ntp-patch
$ diff ntp-4.2.8p3/ntpd/refclock_pcf.c
output/build/ntp-4.2.8p3/ntpd/refclock_pcf.c
170c170
< #if defined(__GLIBC__) && defined(_BSD_SOURCE)
---
> #if 0

I imagine that this change is better done via patch than sed, if it's
needed at all, but since it is actually doing something, changing it
would be a different topic from removing the second line.

Danomi -



More information about the buildroot mailing list