[Buildroot] [PATCH v7 16/22] rsyslog: fix config file comment style

Clayton Shotwell clayton.shotwell at rockwellcollins.com
Fri Jul 10 23:16:45 UTC 2015


Samuel,

>> diff --git a/package/rsyslog/rsyslog.mk b/package/rsyslog/rsyslog.mk
>> index 261f59d..00c313a 100644
>> --- a/package/rsyslog/rsyslog.mk
>> +++ b/package/rsyslog/rsyslog.mk
>> @@ -73,6 +73,10 @@ endef
>>  define RSYSLOG_INSTALL_CONF
>>         $(INSTALL) -m 0644 -D $(@D)/platform/redhat/rsyslog.conf \
>>                 $(TARGET_DIR)/etc/rsyslog.conf
>> +       # Fix invalid config file comment style
>> +       $(SED) 's~\/\* ~#  ~g' $(TARGET_DIR)/etc/rsyslog.conf
>> +       $(SED) 's~ \*\/~# ~g' $(TARGET_DIR)/etc/rsyslog.conf
>> +       $(SED) 's~ \*~# ~g' $(TARGET_DIR)/etc/rsyslog.conf
> Hum... this sed command are not really nice, I would prefer carrying
> the upstream patch fixing this [1].

I agree. I'll change this to the patch instead.

Thanks,
Clayton

Clayton Shotwell
Senior Software Engineer, Rockwell Collins
clayton.shotwell at rockwellcollins.com



More information about the buildroot mailing list