[Buildroot] [PATCH v3] pkg-generic: Fix host _DL_VERSION corner case

[Thomas Petazzoni]

Dear Arnout Vandecappelle (Essensium/Mind),

On Sat, 11 Jul 2015 17:40:14 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> From: Clayton Shotwell <clayton.shotwell at rockwellcollins.com>
> 
> In the case when a package has a host version, the package is dependent
> on the host version, and the version contains a '/', the host version
> does not evaluate properly. The host version will contain a '_' instead
> of a '/', resulting in a failed download. To solve this corner case, add
> a check to see if the _DL_VERSION of the package has been defined before
> defining the host _DL_VERSION. If the package _DL_VERSION has not been
> defined yet, then the version string has not been formatted yet and is
> still good to use.
> 
> [Arnout: further simplify things by lifting the override over _VERSION
> out of the condition - it is always the same.]
> 
> This error occured on a package in a BR2_EXTERNAL that uses a git repo
> for its remote storage with '/' in the tag names. I do not believe this
> affects any packages in the Buildroot mainline but it could in the
> future.
> 
> [Arnout: rebase on master, fix existing whitespace error in the else
> branch.]
> 
> Signed-off-by: Clayton Shotwell <clayton.shotwell at rockwellcollins.com>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> ---
> v3: Re-instate Clayton as author - sorry about that
> v2: rebase, fix whitespace error, lift _VERSION assignment out of condition
> ---
>  package/pkg-generic.mk | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com