[Buildroot] [PATCH] Fix selection of bootloaders from $(BR2_EXTERNAL)

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jul 12 19:54:06 UTC 2015


Dear Arnout Vandecappelle (Essensium/Mind),

On Sun, 12 Jul 2015 19:27:01 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> From: Eric Le Bihan <eric.le.bihan.dev at free.fr>
> 
> If a package is based on "generic-package", pkg-generic.mk will compute
> the name of the Kconfig variable to use for checking if this package has
> been selected by the user.
> 
> Unfortunately, this mechanism does not take into account the case where
> a bootloader is declared in a $(BR2_EXTERNAL)/boot directory.
> 
> So, even if the bootloader has been selected, it will not be added to
> $(TARGETS) and will not be built.
> 
> This patch fixes this issue.
> 
> [Arnout: use single filter line, also apply this to toolchain]
> 
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev at free.fr>
> Cc: Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> ---
> v2: [Arnout]
>   - Use a single filter line instead of copying it for BR2_EXTERNAL
>     (Suggested by Thomas DS)
>   - Add the same feature to toolchain (Suggested by Thomas DS)
> ---
>  package/pkg-generic.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list