[Buildroot] [PATCH 7/7] package/uclibc: check for config file before calling kconfig-package
Baruch Siach
baruch at tkos.co.il
Sun Jul 12 20:06:36 UTC 2015
Hi Yann,
On Sun, Jul 12, 2015 at 02:11:29PM +0200, Yann E. MORIN wrote:
> If we check that the user provides a config file after we call to the
> kconfig-package infra, the error message we get is the one for the
> kconfig-package infra, not the custom error message we want to show to
> the user.
>
> So, only call kconfig-package after we do the check.
The commit log doesn't match the patch. There was no error message before this
patch, AFAICS.
baruch
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> ---
> package/uclibc/uclibc.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index ecbfa11..7dee6b3 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -474,4 +474,10 @@ define UCLIBC_INSTALL_STAGING_CMDS
> $(UCLIBC_INSTALL_UTILS_STAGING)
> endef
>
> +# Checks to give errors that the user can understand
> +# Must be before we call to kconfig-package
> +ifeq ($(BR_BUILDING)$(call qstrip,$(BR2_PACKAGE_BUSYBOX_CONFIG)),y)
> +$(error No uClibc configuration file specified, check your BR2_UCLIBC_CONFIG setting)
> +endif
> +
> $(eval $(kconfig-package))
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
More information about the buildroot
mailing list