[Buildroot] [PATCH v8 11/16] rsyslog: fix config file comment style

Clayton Shotwell clayton.shotwell at rockwellcollins.com
Mon Jul 13 12:25:17 UTC 2015


Thomas,

On Sun, Jul 12, 2015 at 5:51 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Clayton Shotwell,
>
> On Fri, 10 Jul 2015 18:27:57 -0500, Clayton Shotwell wrote:
>> From: Matt Weber <matthew.weber at rockwellcollins.com>
>>
>> The upstream versions of rsyslog (v8 and higher) have this commit to fix
>> the config file comment issue. Carry this patch here until the version
>> is bumped.
>>
>> Signed-off-by: Matthew Weber <matthew.weber at rockwellcollins.com>
>> Signed-off-by: Clayton Shotwell <clayton.shotwell at rockwellcollins.com>
>
> I had to revert this patch, because it was breaking the build:
>
>    http://autobuild.buildroot.org/results/208/2082f4e8dc5768b03c951f571b9aca976703f952/build-end.log
>
> Indeed the patch you proposed to add to rsyslog is already part of
> rsyslog 8.9.0 which we use in Buildroot.
>
> Which means you sent this patch without even trying to apply it on
> rsyslog. Bad! :-)

You are correct. My bad. That is what I get for trying to rush things
before heading out on a Friday.

Thanks,
Clayton

Clayton Shotwell
Senior Software Engineer, Rockwell Collins
clayton.shotwell at rockwellcollins.com



More information about the buildroot mailing list