[Buildroot] [PATCH] autobuild - acpid does not build against musl
Brendan Heading
brendanheading at gmail.com
Mon Jul 20 19:15:04 UTC 2015
Baruch,
> Please spare a few words on what this patch is doing.
Sure.
>> +Some external toolchains using strange C libraries (eg MUSL) do not define
>> +this macro.
>
> What is the upstream status of this patch?
I've not checked. Should I do so before resubmitting ?
I must admit I wasn't too sure about the idea of the patch here, as it
fixes only one package rather than addressing an issue that will
effect any package using the same macro. But I noted a precedent for
this (in the same package, there is a patch to add a macro missing
from unpatched uclibc versions configured as part of an external
toolchain) so I went ahead and submitted.
I can certainly raise it with the upstream devs ..
> Does this patch fix build failure or correctness? Buildroot generally doesn't
> carry warning fix only patches.
Warnings only. I will remove.
Thanks for the feedback on my first ever patch :)
Regards
Brendan
More information about the buildroot
mailing list