[Buildroot] [PATCH V2] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Jul 23 21:11:20 UTC 2015


Dear Guillaume GARDET,

On Thu, 23 Jul 2015 10:45:47 +0200, Guillaume GARDET wrote:
> Reported-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Signed-off-by: Guillaume GARDET <guillaume.gardet at oliseo.fr>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

I applied, but quite a few things were still wrong with the patch:

 * The commit title is too long. It should be less than 80 characters.
   The commit title should only be a summary of the commit log itself.

 * The commit title is wrong: you're no longer adding $(STAGING_DIR) to
   the link path

 * The commit log was missing a reference to the autobuilder failure
   that this patch is fixing.

I've fixed those problems and applied. See:

  http://git.buildroot.net/buildroot/commit/?id=6c73215493335f1ede26cad2d3898ef543d871d6

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list