[Buildroot] [PATCH] Makefile: unexport O

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jul 26 13:07:18 UTC 2015


Dear Guido Martínez,

On Sat, 25 Jul 2015 16:07:39 -0300, Guido Martínez wrote:
> After bee5745ccc2 ("Makefile: don't depend on the umask"), any use
> of "make O=<dir>" would leak $O into the enviroment for submakes,
> and it's inherited by package makefiles. Some package makefiles have
> protections to make sure they don't use the value of $O if it comes from
> the enviroment (Linux), but some don't (uClibc).
> 
> This caused build failures when using a different output dir.
> 
> Fix this by unconditionally unexporting the O variable, since we never
> need to have it set in the environment for packages, it should be only
> internally used by BR.
> 
> Signed-off-by: Guido Martínez <guido at vanguardiasur.com.ar>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list