[Buildroot] [PATCHv2 1/1] xterm: x-includes and x-libraries must be set for cross-compiling
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun Jul 26 19:44:45 UTC 2015
Yann,
On Sun, 26 Jul 2015 19:59:49 +0200, Yann E. MORIN wrote:
> On 2015-07-26 20:46 +0300, kyak spake thusly:
> > From: Mikhail Peselnik <bas at bmail.ru>
> >
> > These flags need to be set so that the configure script would
> > correctly use libICE from cross-toolchain rather than from host.
> > Also, the xterm package is missing the freetype2 dependency, as
> > noted by Romain Naour.
> >
> > This fix is similar to "package/efl/libevas: x-includes and x-libraries
> > must be set for cross-compiling" done by Romain Naour on libecore.
> >
> > Signed-off-by: Mikhail Peselnik <bas at bmail.ru>
>
> The From filed does not match your Signed-off-by; please fix your git
> config with:
>
> git config --global user.name 'Mikhail Peselnik'
> git config --global user.email 'bas at bmail.ru'
Are you sure?
In the patch itself, I see:
From: Mikhail Peselnik <bas at bmail.ru>
Signed-off-by: Mikhail Peselnik <bas at bmail.ru>
which does match. However, it indeed doesn't match the From of the mail
itself:
From: kyak <bas at bmail.ru>
Which I'm not sure is related to the Git configuration. And while it's
a bit ugly, I think it doesn't cause any problem because Git will use
the From: from inside the patch itself in preference over the From: of
the e-mail.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list