[Buildroot] [PATCH 02/12] fs/iso9660: convert to the filesystem infrastructure

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jun 6 00:42:03 UTC 2015


Dear Yann E. MORIN,

On Fri, 5 Jun 2015 22:58:41 +0200, Yann E. MORIN wrote:

> >  ifeq ($(BR2_TARGET_GRUB_SPLASH),)
> 
> I know this was pre-existing code, but we usually prefer positive logic.
> Do you think you might arrange to fix the logic in this test with
> anotehr patch? ;-)

Isn't that already positive logic?

"if BR2_TARGET_GRUB_SPLASH is disabled"

The other solution is:

ifneq ($(BR2_TARGET_GRUB_SPLASH),y)

which is "if not BR2_TARGET_GRUB_SPLASH is enabled"

which looks worse.

Am I missing something?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list