[Buildroot] [PATCH 05/11] package/ktap: use kernel-module helper

Yann E. MORIN yann.morin.1998 at free.fr
Mon Jun 8 21:34:13 UTC 2015


Thomas, All,

On 2015-06-08 23:31 +0200, Yann E. MORIN spake thusly:
> On 2015-06-08 23:25 +0200, Thomas Petazzoni spake thusly:
> > On Sun,  7 Jun 2015 00:20:41 +0200, Yann E. MORIN wrote:
> > >  define KTAP_BUILD_CMDS
> > >  	$(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) $(KTAP_FLAGS) ktap
> > > -	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KERNEL_SRC=$(LINUX_DIR) KVERSION=$(LINUX_VERSION_PROBED) mod
> > >  endef
> > >  
> > >  define KTAP_INSTALL_TARGET_CMDS
> > >  	$(INSTALL) -D -m755 $(@D)/ktap  $(TARGET_DIR)/usr/bin/ktap
> > > -	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KERNEL_SRC=$(LINUX_DIR) KVERSION=$(LINUX_VERSION_PROBED) modules_install
> > >  endef
> > 
> > I think you are effectively getting rid of the KERNEL_SRC definition
> > here. Did you test that it was working OK without this variable?
> 
> Well, it does build a kernel module, yes.

Sorry, I sent too early, forgot to say:

KERNEL_SRC is used i ktap's Makefile only to run commands like:

    $(MAKE) -C $(KERNEL_SRC) M=$(PWD) modules

So, since that's our infra now doing that, KERNEL_SRC is no longer
needed.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list