[Buildroot] [PATCH 01/11] package-infra: add helper to build kernel modules

[Arnout Vandecappelle]

On 06/08/15 23:58, Yann E. MORIN wrote:
> Arnout, All,
> 
> On 2015-06-08 23:52 +0200, Arnout Vandecappelle spake thusly:
>> On 06/08/15 23:44, Yann E. MORIN wrote:
>>> On 2015-06-08 23:09 +0200, Arnout Vandecappelle spake thusly:
>>>> On 06/07/15 00:20, Yann E. MORIN wrote:
>>>>> +# Duplicate that from pkg-generic because we need it now
>>>>> +ifndef $(2)_MAKE
>>>>> +  $(2)_MAKE = $(MAKE)
>>>>> +endif
>>>>
>>>>  I don't see why this is needed... The defines below will only be expanded when
>>>> the rule is executed (otherwise $(PKG) would not even be defined), so the
>>>> definition from pkg-generic is enough, no?
>>>
>>> Well, I tried to remove it, and it does not work (indetation added by me):
>>
>>  D'oh, it's actually defined in pkg-autotools, not pkg-generic, but the comment
>> above confused me. Which in fact makes the comment redundant, because it's not a
>> redifinition.
> 
> Ah, yes, right, my bad.
> 
> I tested with a generic-package. Maybe an autotools-package (or any
> other infra) would have no issue, since it is defined for them.
> 
>>  That said, I think it's better like this:
>>
>> $(2)_MAKE ?= $$(MAKE)
> 
> Yup, I'll do (already usinf $$(MaKE) locally.

 I also mean ?= is better than ifndef.

 Regards,
 Arnout

> 
> Thanks! :-)
> 
> Regards,
> Yann E. MORIN.
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F