[Buildroot] [PATCH 1/1] libarchive: add hash and enable lzma support

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jun 27 14:12:02 UTC 2015


Dear Nimai Mahajan,

On Fri, 26 Jun 2015 15:32:52 -0400, Nimai Mahajan wrote:

> > In his review, Arnout asked you to pass --with-lzma in this case, but
> > you forgot to do it. So I've that and applied. Thanks!
> 
> Thanks, I had seen that actually but I was trying to be consistent with the
> other options there, which specified the package dependency (i.e. zlib)
> followed by the configure options if it wasnt selected (i.e. without-zlib).
> But point taken.

In general, when Arnout makes a suggestion, he is right :-)

In this specific case, the rest of libarchive.mk is in fact not good,
and should be changed to explicitly pass --with-<foo>.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list