[Buildroot] [PATCH 4/5] package/efl/libevas: Switch to giflib
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sat Mar 7 16:32:34 UTC 2015
Dear Fabio Porcedda,
On Sat, 7 Mar 2015 17:29:56 +0100, Fabio Porcedda wrote:
> IMHO it's cleaner if instead of adding this patch you can add a
> post_patch hook that using sed change all "DGifCloseFile(gif)" to
> "DGifCloseFile(gif, NULL)".
I don't agree. Such sed expressions can very easily be overlooked when
bumping the package, and they don't solve a problem that should be
solved by submitting a patch to the upstream project.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list