[Buildroot] [PATCH 1/1] package/zeromq: enable kernel-based feature flags

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Mar 16 08:05:08 UTC 2015


Dear Lionel Orry,

On Mon, 16 Mar 2015 07:43:11 +0100, Lionel Orry wrote:

> > So, replace AC_TRY_RUN with AC_TRY_LINK or something like that. Or
> > maybe there's even a simpler autoconf macro to test if a definition
> > exists or not.
> 
> the fact is, I was asked by Arnout to do it that way, and his opinion
> was that it was needed to run the snippet on the target to be sure of
> the resut. See:
> http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/106055
> 
> Is there something I misunderstood ? Who has the final call about this ?

I am not sure I agree with Arnout suggestion, but...

> > Also, did you submit your patch upstream?
> 
> Yes I did, it has been merged into the next branch of zeromq, v4.1.x.

... since your patch has been merged upstream, I'm just fine with using
it as is.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list