[Buildroot] [PATCH v2 23/25] avahi: systemd cleanups

[Mike Williams]

Thomas,

On Fri, Mar 20, 2015 at 3:41 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Mike Williams,
>
> On Fri, 20 Mar 2015 15:14:14 -0400, Mike Williams wrote:
>
>> +ifneq ($(BR2_PACKAGE_SYSTEMD),y)
>> +AVAHI_CFLAGS += -DDISABLE_SYSTEMD
>> +endif
>
> Seriously, do you test the patches you send? I really value the
> contributions you're making around systemd support: it's great to have
> someone finally picking up this topic and doing some
> cleanup/refactoring. But please, test your patches at least minimally.

Yes, I built, booted it, and verified that systemd started it without
error. I mistakenly assumed that meant it the patch was working
correctly; I don't use avahi for anything and have no experience with
it.

> The <pkg>_CFLAGS variable does not exist and has no effect.

I see that now. I fgrep'd for _CFLAGS initially to find out how other
packages were doing it, and didn't realize this common convention
wasn't part of buildroot.

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com