[Buildroot] [PATCH 3/3] package/wvstreams: add argp-standalone as optionnal dependency

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri May 1 21:04:02 UTC 2015


Dear Romain Naour,

On Fri,  1 May 2015 18:44:46 +0200, Romain Naour wrote:
> This ensures the build reproducibility.
> 
> Signed-off-by: Romain Naour <romain.naour at openwide.fr>
> ---
>  package/wvstreams/wvstreams.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/wvstreams/wvstreams.mk b/package/wvstreams/wvstreams.mk
> index bc7c5d4..3db317a 100644
> --- a/package/wvstreams/wvstreams.mk
> +++ b/package/wvstreams/wvstreams.mk
> @@ -32,6 +32,11 @@ ifneq ($(BR2_STATIC_LIBS),y)
>  WVSTREAMS_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fPIC"
>  endif
>  
> +# wvstreams use argp.h which can be provided by argp-standalone package.
> +ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> +WVSTREAMS_DEPENDENCIES += argp-standalone
> +endif

Applied after fixing typos in the commit title and comment.

I wonder if we shouldn't make the argp-standalone package only
available on !glibc builds, since glibc provides its own argp
implementation.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list