[Buildroot] [PATCH 2/2] powerpc-utils: remove --without-librtas

Baruch Siach baruch at tkos.co.il
Fri May 8 04:57:58 UTC 2015


Hi Sam,

On Fri, May 08, 2015 at 02:27:49PM +1000, Sam Bobroff wrote:
> Now that librtas is available, remove --without-librtas and make the
> rtas-dependant functions available.
> 
> Signed-off-by: Sam Bobroff <sam.bobroff at au1.ibm.com>
> ---
>  package/powerpc-utils/Config.in        |    1 +
>  package/powerpc-utils/powerpc-utils.mk |    3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/powerpc-utils/Config.in b/package/powerpc-utils/Config.in
> index eded41e..a754899 100644
> --- a/package/powerpc-utils/Config.in
> +++ b/package/powerpc-utils/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_POWERPC_UTILS
>  	bool "powerpc-utils"
>  	depends on BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
>  	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_LIBRTAS
>  	help
>  	  System utilities for PowerPC machines.
>  
> diff --git a/package/powerpc-utils/powerpc-utils.mk b/package/powerpc-utils/powerpc-utils.mk
> index 3b30458..3fb9e24 100644
> --- a/package/powerpc-utils/powerpc-utils.mk
> +++ b/package/powerpc-utils/powerpc-utils.mk
> @@ -6,11 +6,10 @@
>  
>  POWERPC_UTILS_VERSION = 1.2.24
>  POWERPC_UTILS_SITE = http://downloads.sourceforge.net/project/powerpc-utils/powerpc-utils
> -POWERPC_UTILS_DEPENDENCIES = zlib
> +POWERPC_UTILS_DEPENDENCIES = zlib librtas

Why not make librtas an optional dependency? Something like:

ifeq ($(BR2_PACKAGE_LIBRTAS),y)
POWERPC_UTILS_DEPENDENCIES += librtas
POWERPC_UTILS_CONF_OPTS = --with-librtas
else
POWERPC_UTILS_CONF_OPTS = --without-librtas
endif

>  POWERPC_UTILS_LICENSE = Common Public License Version 1.0
>  POWERPC_UTILS_LICENSE_FILES = COPYRIGHT
>  
> -POWERPC_UTILS_CONF_OPTS = --without-librtas
>  POWERPC_UTILS_CONF_ENV = \
>  	ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no)

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list