[Buildroot] [PATCH] package/gauche: remove unnecessary files for target, fix a typo

Hiroshi Kawashima kei-k at ca2.so-net.ne.jp
Wed Nov 11 14:14:11 UTC 2015


Dear Thomas.

Thank you for your suggestion.
As you are maintainer, I will obey your opinion anyway.

But both approach is same 10 lines.
Just my preference is direct approach will have good readability if same size.

Regards,
Kawashima

> 2015/11/11 22:59、Thomas Petazzoni <thomas.petazzoni at free-electrons.com> のメール:
> 
> Arnout, Hiroshi,
> 
> On Tue, 10 Nov 2015 21:54:35 +0100, Arnout Vandecappelle wrote:
> 
>>> +define GAUCHE_REMOVE_UNNEEDED
>>> +	for i in gauche-config gauche-install gauche-package ; do \
>>> +		rm -f $(TARGET_DIR)/usr/bin/$$i ; \
>>> +		rm -f $(TARGET_DIR)/usr/lib/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/$(GNU_TARGET_NAME)/$$i ; \
>>> +	done
>>> +	for i in gencomp genstub precomp ; do \
>>> +		rm -f $(TARGET_DIR)/usr/share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/lib/$$i ; \
>>> +	done
>>> +	rm -f $(TARGET_DIR)/usr/share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/aclocal.m4
>>> +	rm -f $(TARGET_DIR)/usr/share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/template.*
>>> +	rm -fr $(TARGET_DIR)/usr/lib/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/include
>> 
>> This cleanup is quite complicated and I wonder if it is really worth it. For
>> space, the impact is really small compared to the 3MB of libs and .scm files
>> installed by the package. Even the ones in /usr/bin I'm not sure if it's worth
>> to remove them.
>> 
>> Thomas, what do you think?
> 
> I also think it is quite noisy, at least the way it is written. However
> I like to have on the target only what's needed.
> 
> Hiroshi, do we really need to be so fine-grained when removing things?
> 
> Maybe we could do:
> 
> GAUCHE_FILES_TO_CLEANUP = \
> 	$(foreach p,gauche-config gauche-install gauche-package,\
> 		bin/$(p) lib/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/$(GNU_TARGET_NAME)/$(p)) \
> 	$(foreach p,gencomp genstub precomp,\
> 		share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/lib/$(p)) \
> 	share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/aclocal.m4 \
> 	share/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/template.* \
> 	lib/gauche-$(GAUCHE_VERSION_MAJOR)/$(GAUCHE_VERSION)/include
> 
> And then use that variable:
> 
> 	$(foreach p,$(GAUCHE_FILES_TO_CLEANUP),\
> 		$(RM) -rf $(TARGET_DIR)/usr/$(p)$(sep))
> 
> But it's not significantly better :/
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot




More information about the buildroot mailing list