[Buildroot] [PATCH 05/21 RFC] core/pkg-virtual: ignore from legal-info output

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Nov 17 11:25:23 UTC 2015


Yann,

On Mon, 16 Nov 2015 23:47:00 +0100, Yann E. MORIN wrote:
> Virtual packages really have nothing to save for legal-info, so we just
> ignore them.
> 

> Following patches will always extract-and-aptch non-ignored packages, so
> we would potentially see spurious "extracting" and "patching" messages
> on the console, which would be a bit strange. Ignoring virtual packages
> will get us a cleaner log.

aptch -> patch. And the extract-and-patch can be just "extract and
patch".

It's also not really clear what you mean by "Following patches will
always extract and patch non-ignored packages". Aren't we already doing
that for legal-info ? (Note: I haven't looked at the following patches
yet, things might get clearer when I'll reach the next patches, but it
seems weird to not understand a commit log if you haven't read the next
patches).

Otherwise, I'm fine with the change, as soon as we reach an agreement
on PATCH 04/21.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list