[Buildroot] [PATCH 05/21 RFC] core/pkg-virtual: ignore from legal-info output

Yann E. MORIN yann.morin.1998 at free.fr
Tue Nov 17 19:35:15 UTC 2015


On 2015-11-17 12:25 +0100, Thomas Petazzoni spake thusly:
> Yann,
> 
> On Mon, 16 Nov 2015 23:47:00 +0100, Yann E. MORIN wrote:
> > Virtual packages really have nothing to save for legal-info, so we just
> > ignore them.
> > 
> 
> > Following patches will always extract-and-aptch non-ignored packages, so
> > we would potentially see spurious "extracting" and "patching" messages
> > on the console, which would be a bit strange. Ignoring virtual packages
> > will get us a cleaner log.
> 
> aptch -> patch. And the extract-and-patch can be just "extract and
> patch".

Damn, I missed fixing that (I used it elsewhere and then fixed those,
missed that one).

> It's also not really clear what you mean by "Following patches will
> always extract and patch non-ignored packages". Aren't we already doing
> that for legal-info ? (Note: I haven't looked at the following patches
> yet, things might get clearer when I'll reach the next patches, but it
> seems weird to not understand a commit log if you haven't read the next
> patches).

No, we only extract them if they define a non-empty _LICENSE_FILES.

> Otherwise, I'm fine with the change, as soon as we reach an agreement
> on PATCH 04/21.

Ack. Two options, then:

  - keep YES/NO, add IGNORE (or NOTHING)
  - replace YES/NO with ALL, METADATA, NOTHING (and keep YES/NO for
    backward compatibility to ALL/METADATA).

(or a third naming, whatever...)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list