[Buildroot] [git commit] Makefile: Remove 'quiet' variable
Peter Korsgaard
peter at korsgaard.com
Wed Oct 28 23:04:05 UTC 2015
commit: http://git.buildroot.net/buildroot/commit/?id=474d39a1ffad52618e2d1f0afcd527a5aadd5ec1
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
'quiet' variable is set and exported, but it is not used. We can safely
remove it.
This variable is inherited from the Makefile of the Linux kernel, and
is not used in Buildroot.
In support/scripts/mkmakefile, 'quiet' value is checked, but the test
is always true ('quiet' is never set to silent_), so the test can be
removed as well.
Signed-off-by: Cédric Marie <cedric.marie at openmailbox.org>
Reviewed-by: "James Knight" <james.d.knight at live.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
Makefile | 4 +---
support/scripts/mkmakefile | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index dd8959f..8e3f657 100644
--- a/Makefile
+++ b/Makefile
@@ -228,14 +228,12 @@ ifndef KBUILD_VERBOSE
endif
ifeq ($(KBUILD_VERBOSE),1)
- quiet =
Q =
ifndef VERBOSE
VERBOSE = 1
endif
export VERBOSE
else
- quiet = quiet_
Q = @
endif
@@ -247,7 +245,7 @@ SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
# kconfig uses CONFIG_SHELL
CONFIG_SHELL := $(SHELL)
-export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE
+export SHELL CONFIG_SHELL Q KBUILD_VERBOSE
ifndef HOSTAR
HOSTAR := ar
diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile
index 833be6a..37162a3 100755
--- a/support/scripts/mkmakefile
+++ b/support/scripts/mkmakefile
@@ -15,9 +15,7 @@ if test -e $2/Makefile && ! grep -q Automatically $2/Makefile
then
exit 0
fi
-if [ "${quiet}" != "silent_" ]; then
- echo " GEN $2/Makefile"
-fi
+echo " GEN $2/Makefile"
cat << EOF > $2/Makefile
# Automatically generated by $0: don't edit
More information about the buildroot
mailing list