[Buildroot] [PATCH v4 1/3] skeleton: Clean up profile file

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Oct 4 14:55:11 UTC 2015


Maxime,

On Sat,  3 Oct 2015 16:53:20 +0200, Maxime Hadjinlian wrote:
> There's a lot of code in /etc/profile, which doesn't really belong in a
> minimal default skeleton.
> 
> Also, add an 'unset i' to avoid clutter.
> 
> If the user has a specific needs, it needs to be added in
> /etc/profile.d/ by a post-build script.
> 
> Signed-off-by Maxime Hadjinlian <maxime.hadjinlian at gmail.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> ---
> v3 -> v4:
>     - Enclose export PS1 in a "if [ "$PS1" ]; then" so it's only for an
>       interactive session.
>     - Fix commit log (add unset i)
> v1 -> v2:
>     - Don't change indent and don't fix 'pretty' stuff
>     - Keep PS1 , PAGER and EDITOR setted.
>     - At the end of the for loop, add unset i
> ---
>  system/skeleton/etc/profile         | 56 +++++--------------------------------
>  system/skeleton/etc/profile.d/umask |  1 +
>  2 files changed, 8 insertions(+), 49 deletions(-)
>  create mode 100644 system/skeleton/etc/profile.d/umask

All three patches applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list