[Buildroot] [PATCH v3] libv4l: bump version to 1.8.0
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue Oct 13 21:04:55 UTC 2015
Dear Peter Seiderer,
On Tue, 13 Oct 2015 21:25:34 +0200, Peter Seiderer wrote:
> If 'ifeq ($(BR2_PACKAGE_QT5BASE)$(BR2_PACKAGE_QT5BASE_GUI)$(BR2_PACKAGE_QT5BASE_WIDGETS),yyy)'
> is enough this line could be shorten to 'else ifeq ($(BR2_PACKAGE_QT_GUI_MODULE),y)' or
> is it better/clearer to add '$(BR2_PACKAGE_QT5)' to the first one ( I think both
> options will work)?
Yeah, indeed the Qt4 test can be limited to BR2_PACKAGE_QT_GUI_MODULE,
since if this symbol is enabled, surely BR2_PACKAGE_QT is as well.
Though I found it more explicit to also indicate BR2_PACKAGE_QT, even
if not strictly necessary.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list